fix: List page crashes and missing rows by Cragsmann · Pull Request #40 · functions-dev/ocp-console-plugin

Cragsmann · 2026-06-15T09:34:53Z

Summary

Add per-repo error handling in loadFunctionTableItems so a deleted GitHub repo no longer crashes the entire list page (repos that fail to load are silently skipped)
Use function name from func.yaml instead of repo name as the correlation key, so cluster matching works when the two differ
Rename parseNamespaceAndRuntime to parseFuncYaml and extract the name field

Fixes SRVOCF-840

Test plan

Delete a function repo from GitHub, click Refresh on list page. Page shows remaining functions (or empty state) without crashing
Create a repo where func.yaml name differs from repo name. List page shows the func.yaml name and matches cluster status correctly
Unit tests pass (131 total, 5 new)

matejvasek · 2026-06-15T11:24:23Z

via Claude:

Review

Blocking

Edit link breaks when func.yaml name differs from repo name.

The list page now uses the func.yaml name as the item name (FunctionsListPage.tsx:227: newItem(name || repo.name, ...)), and the edit link navigates using that name (FunctionsListPage.tsx:208: navigate(\/faas/edit/${name}`)`).

But resolveRepoContent in FunctionEditPage.tsx:193 looks up repos by GitHub repo name: repos.find((r) => r.name === repoName).

When func.yaml has name: my-function but the repo is named my-repo:

List page shows my-function
Clicking edit navigates to /faas/edit/my-function
resolveRepoContent searches for a repo named my-function, finds nothing
Edit page fails

The FunctionTableItem (or the edit route) needs to carry the repo name alongside the display name so that resolveRepoContent can resolve correctly.

Non-blocking

Silent error swallowing (FunctionsListPage.tsx:228-229): Bare catch drops all errors, not just 404s from deleted repos. Network timeouts and rate limits would silently hide repos with no indication to the user.

Cragsmann · 2026-06-16T11:52:58Z

Both issues confirmed and fixed:

1. Edit link (blocking): Added repoName field to FunctionTableItem. The edit button now passes fn.repoName (the GitHub repo name) instead of fn.name (the func.yaml display name), so resolveRepoContent resolves correctly even when they differ. Added a test covering the divergent-name case.

2. Silent error swallowing (non-blocking): Changed the bare catch to log via console.warn with the repo name and error message, so network timeouts and rate limits are visible instead of silently dropped.

matejvasek · 2026-06-17T18:40:04Z

Looks good to me.

@twoGiants are we OK with just logging the error for a developers into console,
or do we want error reported also to WebUI?

matejvasek · 2026-06-18T15:58:28Z

plz update ./docs/claude-progress.txt

When fetchFileContent fails for a repo, return an error table item instead of null. This surfaces the failure to the user rather than silently hiding the repo from the list. Co-Authored-By: Claude <noreply@anthropic.com>

The list page now shows failed repos as error items instead of dropping them. Update the test to expect both items in the table and verify the failed repo appears by name. Co-Authored-By: Claude <noreply@anthropic.com>

matejvasek · 2026-06-19T11:46:52Z

  if (!funcYaml) return '';

-  const { runtime } = parseNamespaceAndRuntime(funcYaml.content);
+  const { runtime } = parseFuncYaml(funcYaml.content);


This may also throw if there is syntax error in func.yaml, which results in infinite "Loading sources…".

Screencast.From.2026-06-19.13-44-41.mp4

However feel free to create separate bugreport/pr for this if you want.

matejvasek · 2026-06-19T11:54:01Z

This looks IMO good.

Two nits:

Claude suggested using em dash instead of <UNKNOWN> (AI loves them em dashes don't it 😄). Perhaps returning namespace/runtime as an empty string results in em dashes in the table automatically.
Should not we keep the logging to console for developers sake? wdyt?

matejvasek · 2026-06-19T11:56:01Z

    }),
  );
-  return items;
+  return results.filter((item): item is FunctionTableItem => item !== null);


Since we are returning nulls no more we might not need this filter.

Issue addresed in Openshift repo's PR openshift#4

Replace '<UNKNOWN>' with empty strings so TextOrDash renders em dashes automatically. Add console.error for developer debugging. Remove the null filter since the catch block always returns an item now. Co-Authored-By: Claude <noreply@anthropic.com>

Cragsmann · 2026-06-19T12:19:00Z

PR opened in Openshift repo openshift#4

SRVOCF-840: Fix list page crashes and missing rows

845ef68

Cragsmann changed the title ~~SRVOCF-840: Fix list page crashes and missing rows~~ fix: List page crashes and missing rows Jun 15, 2026

SRVOCF-840: fix lint import

337bb6b

SRVOCF-840: fix review comments

4cde369

Cragsmann requested review from matejvasek and twoGiants June 17, 2026 14:39

matejvasek reviewed Jun 18, 2026

View reviewed changes

Comment thread src/pages/function-list/FunctionsListPage.tsx Outdated

Cragsmann and others added 2 commits June 19, 2026 09:55

fix: show error items instead of dropping repos

eb2573b

When fetchFileContent fails for a repo, return an error table item instead of null. This surfaces the failure to the user rather than silently hiding the repo from the list. Co-Authored-By: Claude <noreply@anthropic.com>

Merge branch 'master' into SRVOCF-840--fix-list-page-crashes

62e24bd

Cragsmann requested a review from matejvasek June 19, 2026 07:56

test: update test for error item behavior

9c0ff8e

The list page now shows failed repos as error items instead of dropping them. Update the test to expect both items in the table and verify the failed repo appears by name. Co-Authored-By: Claude <noreply@anthropic.com>

matejvasek reviewed Jun 19, 2026

View reviewed changes

Cragsmann closed this Jun 19, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: List page crashes and missing rows#40

fix: List page crashes and missing rows#40
Cragsmann wants to merge 7 commits into
functions-dev:masterfrom
Cragsmann:SRVOCF-840--fix-list-page-crashes

Cragsmann commented Jun 15, 2026 •

edited

Loading

Uh oh!

matejvasek commented Jun 15, 2026 •

edited

Loading

Uh oh!

Cragsmann commented Jun 16, 2026

Uh oh!

matejvasek commented Jun 17, 2026

Uh oh!

Uh oh!

matejvasek commented Jun 18, 2026

Uh oh!

matejvasek Jun 19, 2026

Uh oh!

matejvasek commented Jun 19, 2026 •

edited

Loading

Uh oh!

matejvasek Jun 19, 2026

Uh oh!

Cragsmann Jun 19, 2026

Uh oh!

Cragsmann commented Jun 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Cragsmann commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

matejvasek commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review

Blocking

Non-blocking

Uh oh!

Cragsmann commented Jun 16, 2026

Uh oh!

matejvasek commented Jun 17, 2026

Uh oh!

Uh oh!

matejvasek commented Jun 18, 2026

Uh oh!

matejvasek Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

matejvasek commented Jun 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matejvasek Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

Cragsmann Jun 19, 2026

Choose a reason for hiding this comment

Uh oh!

Cragsmann commented Jun 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Cragsmann commented Jun 15, 2026 •

edited

Loading

matejvasek commented Jun 15, 2026 •

edited

Loading

matejvasek commented Jun 19, 2026 •

edited

Loading